search

spatie / laravel-newsletter

Manage Mailcoach and MailChimp newsletters in Laravel
https://freek.dev/440-easily-integrate-mailchimp-in-laravel-5
MIT License
1.61k stars 235 forks source link

Fix package register bug #278

Closed binary-scenery closed 2 years ago

binary-scenery commented 2 years ago

Fixes a bug where the package wasn't registering properly due to a lowercase typo

pindab0ter commented 2 years ago

Please provide a way to reproduce the issue. I'm on PHP 8.1, Laravel 9.21.6 and spatie/laravel-newsletter 4.11.0 and I can confirm that it works and that the change in your PR breaks it for me.

binary-scenery commented 2 years ago

Please provide a way to reproduce the issue. I'm on PHP 8.1, Laravel 9.21.6 and spatie/laravel-newsletter 4.11.0 and I can confirm that it works and that the change in your PR breaks it for me.

I think it's only breaking when the server requires the registered package name and the filename of Newsletter to be the same case, which I think depends on server settings, more details here: https://github.com/spatie/laravel-newsletter/issues/166

freekmurze commented 2 years ago

It seems like the current code is already working.