Added architecture tests for facades and enums

spatie / laravel-pdf

Create PDF files in Laravel apps

https://spatie.be/docs/laravel-pdf

MIT License

715 stars 54 forks source link

Added architecture tests for facades and enums #5

Closed ash-jc-allen closed 10 months ago

ash-jc-allen commented 10 months ago

Hey @freekmurze!

Cool package! It's is perfect timing because I've got a client project coming up soon that will hugely benefit from this 😄

This PR is only a small one, but it's just a quick-win that I thought I might be able to contribute. I've added 2 basic architecture tests for the package's enums and facade.

I'm not sure whether these are something you were looking for (so it's totally cool if you want to close this PR), but I thought I'd pitch them just in case. Thanks!

freekmurze commented 10 months ago

Hi Ash,

Thanks for this PR. I'm going to pass on this as I will never see myself adding a non-enum class to enums dir, and a non-facade class to the facades dir.

ash-jc-allen commented 10 months ago

Hey! That's no problem 😄