CHANGELOG.md has forgotten about 1.18.0

spatie / laravel-query-builder

Easily build Eloquent queries from API requests

https://spatie.be/docs/laravel-query-builder

MIT License

4.06k stars 397 forks source link

CHANGELOG.md has forgotten about 1.18.0 #647

Closed Peter-Krebs closed 3 years ago

Peter-Krebs commented 3 years ago

The version 1.18.0 added support for Laravel 6 and PHP 8, according to 1.18.0 changelog.

In version 2.0.0's changelog this change has already been forgotten and doesn't list 1.18.0
The current version (as of this writing) with the changelog for 4.0 also has no mentioning of 1.18.0

I assume this in-between version has been forgotten over time.
Fixing the history of changelogs is not feasable IMO, but could be rectify this lost version in the current changelog?

Thanks!

freekmurze commented 3 years ago

We don't use v1 anymore, so we're not going to invest time it. Feel free to PR changes you need to the v1 version.

Peter-Krebs commented 3 years ago

It is not about V1 for me, it's about representing the correct history in the changelog.
A PR to the v1 branches doesn't do anything - the last v1 version was the 1.18.0 I mentioned. The changelog is correct there, just not the subsequent versions.

If you don't mind forgetting about 1.18.0 in the changelogs since 2.0.0 I don't think I have to care either.
So nevermind, this can stay closed then.