search

spatie / laravel-ray

Debug with Ray to fix problems faster in Laravel apps
https://myray.app
MIT License
291 stars 64 forks source link

Optional rector #331

Closed lloricode closed 9 months ago

IonBazan commented 9 months ago

I think this requirement should not belong here and instead, should be added into suggests section. We could check if the Rector is installed in the CleanRayCommand itself and throw an error if it's not instead of adding a dependency, especially that some people might install spatie/laravel-ray as non-dev dependency, causing Rector to be loaded into their production app.

lloricode commented 9 months ago

I think this requirement should not belong here and instead, should be added into suggests section. We could check if the Rector is installed in the CleanRayCommand itself and throw an error if it's not instead of adding a dependency, especially that some people might install spatie/laravel-ray as non-dev dependency, causing Rector to be loaded into their production app.

I totally aggree regarding usage of production