search

spatie / laravel-slack-alerts

Quickly send a message to Slack
https://freek.dev/2172-a-package-to-quickly-send-slack-alerts-in-a-laravel-app
MIT License
289 stars 33 forks source link

Ignore also '' as webhook URL, not just NULL ones #15

Closed levu42 closed 2 years ago

levu42 commented 2 years ago

in my .env.example is a SLACK_ALERT_WEBHOOK= line as a template for new installations, however that currently fails - other than a totally missing line. The intention of the change in 1.1.0 was to make it not fail in local development environments when slack webhooks are not set up, so I think this change that I propose here is a bugfix to 1.1.0 to implement the intended behavior better.

levu42 commented 2 years ago

Also, in SlackAlert.php this is already the implemented behavior so this fix only makes it more consistent.

freekmurze commented 2 years ago

Could you take a look at the failing tests?

freekmurze commented 2 years ago

Closing due to inactitvity.