search

spatie / laravel-tags

Add tags and taggable behaviour to your Laravel app
https://freek.dev/609-an-opinionated-tagging-package-for-laravel-apps
MIT License
1.62k stars 281 forks source link

JSON field type for migration erroneous #487

Closed kirkbushell closed 8 months ago

kirkbushell commented 12 months ago

Not sure why it's a json field type when json isn't being provided, but the default migration for the tags, specifies both name and slug as JSON fields.

This might work in MySQL, which is a non-standard SQL implementation, but breaks on others, such as Postgres.

Obviously this is easy to fix, as we can publish the migration and change those fields, but it still makes little sense why the migration has JSON fields for those two columns.

I also noticed that columns that -should- be indexed, aren't - as they're queried on within the package itself, namely - slug, and type.

spatie-bot commented 8 months ago

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.