search

spatie / laravel-tags

Add tags and taggable behaviour to your Laravel app
https://freek.dev/609-an-opinionated-tagging-package-for-laravel-apps
MIT License
1.61k stars 281 forks source link

feat: added support for passing locale on multiple HasTags methods #488

Closed Velka-DEV closed 4 months ago

freekmurze commented 9 months ago

Could you add tests and update the readme?

Velka-DEV commented 9 months ago

Could you add tests and update the readme?

I've updated the README with the necessary examples. However, I'm seeking clarification on the types of tests you're expecting. Since this update doesn't introduce new features and mainly involves passing locale to a nested method, I'm unsure about the specific tests needed. Could you provide some guidance on this?

freekmurze commented 9 months ago

The test should execute a method like NewsItem::withAnyTags(['first tag', 'second tag'], locale: 'en')->get(); and verify if you get the results you expect.

Velka-DEV commented 8 months ago

The test should execute a method like NewsItem::withAnyTags(['first tag', 'second tag'], locale: 'en')->get(); and verify if you get the results you expect.

Apologies for the late response, I missed the notification. I've now added tests for the updated methods.

spatie-bot commented 4 months ago

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.