spatie / laravel-web-tinker

Tinker in your browser
https://spatie.be/open-source
MIT License
1.05k stars 68 forks source link

Fix infinite loop using custom execution closure class #55

Closed setkyar closed 4 years ago

setkyar commented 4 years ago

I am fixing the ExecutionLoopClosure class's infinite loop causing a timeout.

Fixes #49

freekmurze commented 4 years ago

This is a lot of code to maintain. Isn't there a simpler solution? The package at some point did work correctly without that heavy class.

setkyar commented 4 years ago

Hi @freekmurze, thanks for the comment. Firstly, my idea was stuck with the existing code. I checked how Tinker does and turns out we can use execute directly.

freekmurze commented 4 years ago

Did you verify in the browser that this fixed the problem?

setkyar commented 4 years ago

@freekmurze I tested in the browser. It's fixed the problem.

freekmurze commented 4 years ago

Thanks!