Add PHP 8 support - Githubissues

spatie / laravel-web-tinker

Tinker in your browser

https://spatie.be/open-source

MIT License

1.05k stars 68 forks source link

Add PHP 8 support #72

Closed eli-s-r closed 3 years ago

eli-s-r commented 3 years ago

Fixes #71

Happy 2021 everybody!

This PR adds support for PHP 8.0. All tests passed locally so hopefully this should be pretty straightforward!

eli-s-r commented 3 years ago

Okay, so it seems that Laravel 8.0.0 didn't support PHP 8 yet since it hadn't been released at that point. Can we use a more recent version of Laravel 8 for the tests?

freekmurze commented 3 years ago

Sure! Feel free to require a higher version.

eli-s-r commented 3 years ago

Okay! Looks like everything's working now.

freekmurze commented 3 years ago

Thanks!