search

spatie / laravel-web-tinker

Tinker in your browser
https://spatie.be/open-source
MIT License
1.05k stars 68 forks source link

avoid infinite loop which terminate process with SIGKILL signal #75

Closed bangnokia closed 3 years ago

bangnokia commented 3 years ago

avoid infinite loop which terminates process with SIGKILL signal when using ExecutionLoopClosure

bangnokia commented 3 years ago

sorry, i didn't run with all testcases in github workflows file before creating merge request. pls ignore this

bangnokia commented 3 years ago

it's seem psysh older versions doesn't have execute or even ExecutionLoopClosure.

freekmurze commented 3 years ago

It seems like a essential test was removed in this PR. Please bring back that test and make sure your code works with it.

bangnokia commented 3 years ago

i wrote that test, but when running on github actions with option prefer-lowest, it used older version of psy/psysh (v0.8.16) which doesn't has functions execute or even ExecutionLoopClosure class. I don't know should remove prefer-lowest in workflows or not so i removed my test.

freekmurze commented 3 years ago

Feel free to up the versions of the used dependencies in composer.json to make the tests pass.

bangnokia commented 3 years ago

i updated the tests workflow :D

spatie-bot commented 3 years ago

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.