spatie / laravel-webhook-client

Receive webhooks in Laravel apps
https://freek.dev/1383-sending-and-receiving-webhooks-in-laravel-apps
MIT License
1k stars 147 forks source link

set default config value to 30 days #175

Closed ankurk91 closed 1 year ago

ankurk91 commented 1 year ago

Hi @freekmurze

The prunable feature was added in PR https://github.com/spatie/laravel-webhook-client/pull/166

The delete_after_days value is set to null by default, and end user is required to set this value in their project. This PR sets the default value to 30 days. This will reduce the steps to setup the ModelPrune command.

Have a default value for delete_after_days is harmless, because it is not effective/used unless developer configures the schedule their-self.

Thanks.

freekmurze commented 1 year ago

Thanks!