search

spatie / laravel-webhook-client

Receive webhooks in Laravel apps
https://freek.dev/1383-sending-and-receiving-webhooks-in-laravel-apps
MIT License
985 stars 146 forks source link

Add a unique token to route names #210

Closed ryanlholt closed 5 months ago

ryanlholt commented 5 months ago

Closes #209

freekmurze commented 5 months ago

Thanks!

ryanlholt commented 5 months ago

Thank you!

it-can commented 5 months ago

This bit me in the *** today... is there a way to disable this? Had to revert to 3.3.0 to have it working again...

Symfony\Component\Routing\Exception\RouteNotFou... ·POST /checkout/payment
Route [webhook-client-mollie] not defined.
freekmurze commented 5 months ago

@ryanlholt seems like this behaviour can be breaking. Could you introduce a config value to enable this behaviour?

it-can commented 5 months ago

this is a problem when using the webhook routes like this:

route('webhook-client-mollie')

in version 3.3.1 the route seems to be:

route('webhook-client-molliejsMQhWja')
ryanlholt commented 5 months ago

@freekmurze I certainly can but it looks like @it-can has an open PR that only needs a slight change to work. Should we default the config value to true since the non-tokenized routes were already breaking documented functionality?