search

spatie / mailcoach-support

Questions and support for Mailcoach
https://mailcoach.app
31 stars 2 forks source link

SendMailJobs all failed, still received campaign confirmation #117

Closed shatterproof closed 4 years ago

shatterproof commented 4 years ago

PHP: 7.4.3 Laravel: 7.2.2 Mailcoach: 2.0.4

Tried to send a scheduled email campaign that initially appeared successful (even received the campaign email confirmation it was sent), but all the SendMailJobs failed several times which caused none of the emails to actually be sent out. My last campaign went out March 19 with no issue, so I'm not sure what could have changed since then besides the Mailcoach 2.0.4 upgrade.

The failed jobs in Horizon were showing one of two different exceptions: Undefined offset: 1 in /home/forge/site/vendor/laravel/framework/src/Illuminate/Redis/Limiters/DurationLimiter.php:107 Undefined offset: 2 in /home/forge/site/vendor/laravel/framework/src/Illuminate/Redis/Limiters/DurationLimiter.php:109

I was able to resolve this by upgrading to the latest version of Mailcoach (2.1.1) and then retrying the jobs manually in Horizon to send them out. However, I am concerned that I received the campaign success email despite all of the jobs failing.

If I hadn't checked Horizon I might not have known the campaign emails were never actually sent out. Could the campaign success email be adjusted to alert if there was an issue sending the campaign?

freekmurze commented 4 years ago

Thanks for reporting.

In the outbox of a sent campaign, you would have seen the failed mails and also a button dispatch jobs to send them.

But indeed, the confirmation mail (and the campaign index screen) should have a warning when there were emails didn't get send correctly.

freekmurze commented 4 years ago

We'll take care of this next week.

shatterproof commented 4 years ago

Awesome, love the package and all the great work you guys do. Thank you!

freekmurze commented 4 years ago

This has been fixed by @riasvdv in the newly tagged v2.4.3