spatie / mailcoach-support

Questions and support for Mailcoach
https://mailcoach.app
31 stars 2 forks source link

The list settings are cached; but it is not persisted. #118

Closed RicardoRamirezR closed 4 years ago

RicardoRamirezR commented 4 years ago

Mailcoah: 2.1.1 Laravel: 7.3.0

When the list is created all goes smooth. Then I've tried to change, for example, the list name. It shows the change in the UI but the change is not persisted.

I dig in the code and have no clue of the solution, but if I do a dd($request->all()); just at the beginning of the EmailListSettingsController@update it does not goes through it.

If I do: Captura de Pantalla 2020-03-25 a la(s) 12 38 16 p  m I dumps the request input.

If I do a php artisan cache:clear it works as it should be.

freekmurze commented 4 years ago

We don't do any caching there, so that's not it.

I've just did a test on a few installations and it seems to be working fine. We also didn't get other reports of this problem. This makes me think that the problem is caused by something specific by your app. Are you using Mailcoach as a package?

Maybe it's validation failing, are you sure that all fields that you enter are valid?

RicardoRamirezR commented 4 years ago

@freekmurze I'm using as a package. I create a new Laravel 7 app then install the package and follow the docs.

I'll check if some validation is failing, but I do not have any validation errors.

RicardoRamirezR commented 4 years ago

@freekmurze yep, it was a validation error.

The validation error message is very small. It wouldn't be nice to show an alert?

The message is present in Welcome mail section, I set Send customized welcome mail and write only the subject.

If I set the subject but not the body Mailcoach will send the default welcome mail but with a personalized subject, which is that I want. I published the views then localized them to Spanish but the subject of Confirmation mail and Welcome mail was only in English. the hack on the database worked until I need to make other changes in the settings.

So, how to have custom subjects then?

freekmurze commented 4 years ago

We'll improve on this soon, probably by scrolling to the first error. @willemvb could you take a look at that?

I'm afraid I don't follow what you want to do with the welcome and/or confirmation mail. If the current options don't offer enough flexibly, you can create your own mailables and use those to send welcome and confirmation mails.

RicardoRamirezR commented 4 years ago

@freekmurze thanks!

When Send customized mail there are choices to send a default or customized mails.

What I did in the database was:

I publish the views and localize them.

The mails are sent with the custom subject and the localized body.

What I mean is that would be nice to have a custom subject.

freekmurze commented 4 years ago

@RicardoRamirezR I'm afraid you'll have to spell it out for me, as I still don't understand what you mean with "custom subject". In the UI we have custom subject fields.

image

If it's an simple change, maybe it's to send me a diff of the changes you want.

freekmurze commented 4 years ago

Closing this due to inactivity and me not understanding the problem.

@RicardoRamirezR Since you have reported this issue, we have opened up the laravel-mailcoach repo. Maybe it's best that you just send us a PR with the change you'd like to see 👍