search

spatie / mailcoach-support

Questions and support for Mailcoach
https://mailcoach.app
31 stars 2 forks source link

Custom segment class not visible in campaign detail #168

Closed electronick86 closed 4 years ago

electronick86 commented 4 years ago

The page /mailcoach/campaigns/42/settings don't show the correct custom segment. It show

I see that the file resources/views/vendor/mailcoach/app/campaigns/draft/partials/emailListFields.blade.php contains
` @if($campaign->usingCustomSegment())

Using custom segment class ({{ $emailList->segment_class }}). 
@else

`

If I'm correct, it should be `
@if($campaign->usingCustomSegment())

Using custom segment class ({{ $campaign->segment_class }}). 
@else

`

Or maybe $campaign->getSegment()->description()?

AUTO_Gocar_Daily_2020-04-28___Mailcoach

Thank you Spatie for the great work!!!

riasvdv commented 4 years ago

Fixed in 2.10.2!

electronick86 commented 4 years ago

Hello Rias,

Is it the message you expect?

Gocar_Daily_2020-05-06___Mailcoach

I have the feeling that (class: {{ $campaign->segment_class }}) is not necessary.

riasvdv commented 4 years ago

You're right, fixed in 2.11.4!

electronick86 commented 4 years ago

thanks!