spatie / mailcoach-support

Questions and support for Mailcoach
https://mailcoach.app
31 stars 2 forks source link

Error htmlspecialchars() trying Delivery tab in a new campaign #169

Closed RicardoRamirezR closed 4 years ago

RicardoRamirezR commented 4 years ago

Captura de Pantalla 2020-04-28 a la(s) 2 33 15 p  m Flare

freekmurze commented 4 years ago

Can you give us some more info on how to recreate this? Do you also get this error for an empty email list and empty html?

Are you using a db that support json columns (like mysql 5.7 or higher)?

On Tue, 28 Apr 2020 at 21:37, Ricardo notifications@github.com wrote:

[image: Captura de Pantalla 2020-04-28 a la(s) 2 33 15 p m] https://user-images.githubusercontent.com/6526545/80529672-694f7400-895d-11ea-8fff-eed7273193f9.png Flare https://flareapp.io/share/87nvX67w

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/spatie/mailcoach-support/issues/169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADWEDIPOM77VAUXR7O3JOTRO4WAJANCNFSM4MTDSJ2A .

-- Freek Van der Herten https://spatie.be +32 495 84 27 91

RicardoRamirezR commented 4 years ago

Thank you @freekmurze. With empty html worked. Then added hello and it fails.

Note: I did enable the Monaco editor...

RicardoRamirezR commented 4 years ago

removed Monaco, same issue...

RicardoRamirezR commented 4 years ago

Mailcoah: 2.9.1 Laravel: 7.9.2 php 7.4.4

Visual 😉

ezgif com-gif-maker-2

RicardoRamirezR commented 4 years ago

When downgrade to Mailcoach 2.7.1 it works

rafahernandez commented 4 years ago

Some comments as I also encountered this, downgrading to 2.7.4 didn't seem to work , I followed the Flare trace and did some debugging, seems like the select inside DateTimeFieldComponent the select are having issues with $hourOptions and $minuteOptions. If I hardcode an array for those values, the error goes away

riasvdv commented 4 years ago

Fixed in 2.10.2! Thanks for the research and reporting