search

spatie / mailcoach-support

Questions and support for Mailcoach
https://mailcoach.app
31 stars 2 forks source link

Options to choose beween comma and semicolon separator when importing .csv #195

Closed rjnicolai closed 4 years ago

rjnicolai commented 4 years ago

Excel exports .csv with a semicolon as separator on default. Mailcoach requires the separator to be a comma. We'd love the option to change the separator in Mailcoach, to make importing more smoothly and simple to understand for our users

freekmurze commented 4 years ago

That makes sense, thanks for your suggestion. We'll take care of making the delimiter configurable soon.

riasvdv commented 4 years ago

This is something you can customize yourself by replacing the mailcoach.actions.import_subscribers action with a class of your own that extends our \Spatie\Mailcoach\Actions\Subscribers\ImportSubscribersAction::class and overwriting the importSubscribers() method (you can basically copy-paste the method and add the useDelimiter option to the SimpleExcelReader)

Implementing this now would require a breaking change in the package as the signature of the class would change. Hope you can solve it this way.

mbardelmeijer commented 4 years ago

This something that can be visited for Mailcoach V3? We notice clients have issues with importing CSV files due to system settings with delimiter. Would love to see native Excel import support for instance (we normally use https://github.com/Maatwebsite/Laravel-Excel for that).

Can PR something into spatie/laravel-mailcoach if wanted?

freekmurze commented 4 years ago

@mbardelmeijer Feel free to submit a PR to v3. We aim to release v3 somewhere next week.