spatie / mailcoach-support

Questions and support for Mailcoach
https://mailcoach.app
31 stars 2 forks source link

Language support #278

Closed ersanserkan closed 3 years ago

ersanserkan commented 3 years ago

Describe your issue

Hello,

I am trying to add Turkish support.

I published lang files with;

php artisan vendor:publish

and added tr.json file to /resources/lang/vendor/mailcoach folder but this does not work.

Do I do anything wrong?


Health check:

Environment: local Debug: ON Horizon: Inactive Queue connection: OK Webhooks: 3 unprocessed webhooks Schedule: hasn't run Default mailer: smtp Mailcoach mailer: ses Campaign mailer: ses Transactional mailer: ses

Technical details

App directory: /Users/xyz/development/mailcoach User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.193 Safari/537.36 PHP version: 7.4.12 MySQL version: 5.7.32 Laravel version: 8.14.0 Horizon version: v5.4.0@d08d10ee12f53b7ba2cbb938eb23857e93fe51d3 laravel-mailcoach version: 3.2.11

riasvdv commented 3 years ago

Make sure your app.locale config key is set to tr, see https://laravel.com/docs/master/localization#configuring-the-locale

ersanserkan commented 3 years ago

Yes, app.locale key is already set to tr

When I change something in de.json and nl.json they are not working too..

freekmurze commented 3 years ago

Did you try clearing the config cache?

php artisan config:clear
ersanserkan commented 3 years ago

Yes, I did it too.

I found this solution while searching.

https://stackoverflow.com/questions/51822028/how-to-override-json-translations-for-a-laravel-package

Is this the correct way while overriding the json translations?

riasvdv commented 3 years ago

Try adding a tr.json to your own project's resources/lang folder

freekmurze commented 3 years ago

Closing due to inactivity.