search

spatie / mixed-content-scanner

Scan a HTTPS-site for mixed content
https://spatie.be/open-source
MIT License
98 stars 16 forks source link

Add tests to GitHub actions workflow #46

Closed SamuelNitsche closed 3 years ago

SamuelNitsche commented 3 years ago

After updating the package to support php 8 I noticed that the GitHub actions don't actually perform the tests (which failed). This PR fixes this.

To actually fix the tests I had to make the following changes:

  1. Update the method to set the total crawl limit (which changed with the new version of the crawler)

  2. Update the server start command. The old command failed with this error message.

    Invalid address: localhost:9000/

    Looks like php 8 does not support starting dev servers with a trailing slash in the server address

freekmurze commented 3 years ago

Thanks!