search

spatie / pdf-to-image

Convert a pdf to an image
https://murze.be/2015/07/convert-a-pdf-to-an-image-using-php/
MIT License
1.3k stars 228 forks source link

Fix failing tests #205

Closed patinthehat closed 1 year ago

patinthehat commented 1 year ago

This PR adds the pestphp/pest-plugin composer plugin to the list of allowed plugins in the composer.json file.

It also updates the test workflow to use the latest ghostscript version, which was causing tests to fail (#198). Also, this PR loads the PDF file after creating the Imagick instance.

Additionally, it implements some of the code from #199, authored by @bobvandevijver, to fix the failing tests:

This PR should allow PRs #198 and #199 to be closed.

id:allow-pest-plugin/v1

freekmurze commented 1 year ago

Thanks!

bobvandevijver commented 1 year ago

Thanks, great to see that my changes have finally been "merged" to main, apparently my name was the blocker?

patinthehat commented 1 year ago

@bobvandevijver Not at all, I simply merged several PRs into a single PR to streamline the process. I've updated the description of this PR to make it clear that you authored the code I merged. Thank you for the contribution! :+1: