spatie / period

Complex period comparisons

https://spatie.be/open-source

MIT License

1.56k stars 72 forks source link

add draft for EndlessPeriod #52

Closed andreybolonin closed 4 years ago

andreybolonin commented 4 years ago

@brendt Hello, can you check and explain, this is a right way?

41

brendt commented 4 years ago

Hey Andrey

This looks more like it, though the implementation is still incorrect, right?

andreybolonin commented 4 years ago

Yep, I still working on it.

I think, can finish on one or two weeks.

brendt commented 4 years ago

Looking forward to it. Be sure to keep edge cases like these in mind:

A [===========…
B       [=====]

OVERLAP [=====]

A [===========…
B       [=====…

OVERLAP [=====…

[==… indicating an endless period

bendavies commented 4 years ago

very cool. remember that no start date, with an end date could also be valid.

spatie-bot commented 4 years ago

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.