search

spatie / period

Complex period comparisons
https://spatie.be/open-source
MIT License
1.56k stars 72 forks source link

Support multiple precisions when checking touchesWith #68

Closed ahallhognason closed 3 years ago

ahallhognason commented 3 years ago

Closes #67

I have updated the tests to add a check with Precision::SECOND and confirmed that the updated touchesWith method now supports multiple precisions (seconds, days, etc).

ahallhognason commented 3 years ago

@brendt I extended the existing test for determining if two periods touched. I hope that's alright.

ahallhognason commented 3 years ago

Looks good to me, but please remove all styling changes and keep the trailing commas.

I removed the last commit that removed the trailing commas. It might be worth dropping support for PHP 7.1 and 7.2 if you want to keep trailing commas, since those versions of PHP will break on this package.

brendt commented 3 years ago

I'll fix that on master, thanks!

brendt commented 3 years ago

Fixed with 1.5.1: https://github.com/spatie/period/releases/tag/1.5.1

ahallhognason commented 3 years ago

Would you mind changing the label to hacktoberfest-accepted? It looks like they are quite particular on the label.

freekmurze commented 3 years ago

There you go!