search

spatie / pest-plugin-snapshots

Add snapshot testing capabilities to Pest
https://pestphp.com
MIT License
35 stars 11 forks source link

Uses default snapshots path #2

Closed nunomaduro closed 4 years ago

nunomaduro commented 4 years ago

Since pest files are not really classes, the snapshot directory ends up being on the vendor folder.

This pull request fixes that issue, overriding both getSnapshotDirectory and getSnapshotId without actually using inheritance.

Note that, this pull request can only be merged once https://github.com/spatie/phpunit-snapshot-assertions/pull/99 is merged and phpunit-snapshot-assertions is released on the version 4.2.2.

freekmurze commented 4 years ago

Thanks!

romainnorberg commented 4 years ago

Thanks