search

spatie / phpunit-snapshot-assertions

A way to test without writing actual test cases
https://spatie.be/courses/testing-laravel-with-pest/snapshot-testing
MIT License
641 stars 70 forks source link

Use `LIBXML_HTML_NODEFDTD` to maintain output consistency #141

Closed JayBizzle closed 2 years ago

JayBizzle commented 2 years ago

Fix for #140

JayBizzle commented 2 years ago

Can you run this workflow to prove the failing test does indeed fail please...

https://github.com/spatie/phpunit-snapshot-assertions/actions/runs/2415063695

Thanks

freekmurze commented 2 years ago

Thanks!

JayBizzle commented 2 years ago

Hmmm...I expected that first commit to fail the tests. It fails for me :/

I didn't expect you to merge whilst still marked at a draft. I think this requires further investigation and should be reverted as people may be relying on the unexpected output tor their tests to pass

JayBizzle commented 2 years ago

This has fixed all our issues. Hopefully it works for others as expected.