search

spatie / ray

Debug with Ray to fix problems faster
https://myray.app
MIT License
574 stars 102 forks source link

Expanding doesn't always happen #579

Closed jasonvarga closed 3 years ago

jasonvarga commented 3 years ago

Describe the bug

Sometimes, expanding objects doesn't work.

Here you can see config and request work, but events doesn't. The arrow toggles, but nothing appears.

Screen Capture on 2021-10-18 at 15-24-29

I'm aware this is the Symfony var dumper, but when I try to expand the same thing in the browser it works.

Versions Ray: 1.17.1 spatie/ray: 1.26.1 spatie/laravel-ray: 1.30.3 PHP: 8.0.11 Laravel: 8.64.0

To Reproduce Steps to reproduce the behavior:

  1. ray(app())
  2. Expand instances, then expand events. (There's nothing special about events. Maybe it'll work. Maybe others won't.)

Expected behavior It should expand.

Desktop (please complete the following information):

AdrianMrn commented 3 years ago

@jasonvarga Thanks for the detailed report!

I haven't been able to reproduce this. I noticed in your gif that for the first 2 you clicked the arrow, and for the last only the label, could you please see if that's where the bug originates? Knowing this would make it easier for me to figure out a fix 🙏

If this isn't the cause of the issue, would it be possible for you to set up a minimal repository where I can easily reproduce this please?

jasonvarga commented 3 years ago

Good catch on the arrows, but that doesn't look like it changes anything.

https://github.com/jasonvarga/ray-expand-bug

Visit / with ray open, then click through some items inside instances.

Screen Capture on 2021-10-19 at 09-09-06

AdrianMrn commented 3 years ago

Thanks a bunch for the repo, I've managed to fix this issue. This change will be included in 1.18.0, which will be releasing later this week :)

jasonvarga commented 3 years ago

That was fast. Awesome, thank you!

I'm curious what the problem was, if you don't mind?

AdrianMrn commented 3 years ago

We were using the wrong version of the symfony dump script to evaluate the html, so I've changed how the script is loaded :)