Fix null/false confusion

spatie / robots-txt

Determine if a page may be crawled from robots.txt, robots meta tags and robot headers

https://spatie.be/en/opensource/php

MIT License

219 stars 36 forks source link

Fix null/false confusion #16

Closed BenMorel closed 5 years ago

BenMorel commented 5 years ago

file_get_contents() returns false on failure
the ?? operator only handles null values

=> right now, when file_get_contents() fails, it is not converted to '', but false is passed to the constructor; this only works because strict_types is off, and the value is implicitly converted to string due to the type-hint.

freekmurze commented 5 years ago

Thanks!