search

spatie / server-side-rendering

Server side rendering JavaScript in a PHP application
https://sebastiandedeyne.com/posts/2018/server-side-rendering-javascript-from-php
MIT License
602 stars 34 forks source link

make context variable configurable #53

Closed mercs600 closed 2 years ago

mercs600 commented 2 years ago

I would like to change the "context" variable to something else - if it comes to node environment only the variable name is ok, but I use it also on frontend (https://github.com/spatie/server-side-rendering/issues/52) so it may be conflict with other global variables. I was thinking about make this variable name as configurable option. https://github.com/spatie/server-side-rendering/blob/main/src/Renderer.php#L193

I could prepare PR if you are ok with that.

spatie-bot commented 2 years ago

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.