search

spatie / sheets

Store & retrieve your static content in plain text files
https://spatie.be/open-source
MIT License
273 stars 21 forks source link

FilesystemRepository::all() return should have path as array key #37

Closed Gummibeer closed 4 years ago

Gummibeer commented 4 years ago

The \Spatie\Sheets\Repositories\FilesystemRepository::all() return should be keyed by the path. This is needed to render an index view which needs the path to link to the corresponding sheet.

sebastiandedeyne commented 4 years ago

Hmm I don't think I agree with this change. It's a collection of items, and I'd expect a numeric index for these.

A better solution would be to add the path to the Sheet object.