spatie / statamic-responsive-images

Responsive images for Statamic 3
MIT License
99 stars 29 forks source link

Problem with Dirty State? #120

Closed intrepidws closed 1 year ago

intrepidws commented 2 years ago

As part of upgrading to Statamic 3.3, I also upgraded from v2.9.3 of this package to v2.11.0. I am running into an issue that I believe traces back to usage of the responsive fieldtype made available by this package.

There are two issues occurring:

Screen Shot 2022-04-14 at 1 26 28 PM

I am running PHP 8.1, Laravel 8.83.8, Statamic 3.3.6 and Statamic Responsive Images 2.11.0.

Author Collection Blueprint YAML

title: Authors
sections:
  main:
    display: Main
    fields:
      -
        handle: title
        field:
          type: text
          required: true
          validate:
            - required
          display: Name
          listable: true
          input_type: text
          antlers: false
      -
        handle: job_title
        field:
          input_type: text
          antlers: false
          display: 'Job Title'
          type: text
          icon: text
          listable: true
      -
        handle: header_photo
        field:
          use_breakpoints: false
          allow_ratio: false
          allow_fit: true
          breakpoints:
            - sm
            - md
            - lg
            - xl
            - 2xl
          container: assets
          folder: headers
          restrict: false
          allow_uploads: true
          display: Photo
          type: responsive
          icon: assets
          listable: hidden
          instructions_position: above
          read_only: false
          validate:
            - required
  sidebar:
    display: Sidebar
    fields:
      -
        handle: slug
        field:
          type: slug
          localizable: true
          validate:
            - required
          listable: hidden
          generate: true
intrepidws commented 2 years ago

Note that if you do either of the below, you do not get the browser message:

spatie-bot commented 1 year ago

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.

ncla commented 1 year ago

Shoo, @spatie-bot. Both the dirty state and required validation are still broken. I have tested this, it is indeed broken, and there might be a fix soon.

ncla commented 1 year ago

The dirty state issue should be improved with v2.13.1 update.

intrepidws commented 1 year ago

Hey @ncla, I finally got around to testing this and just wanted to thank you for fixing this issue.