spatie / statamic-responsive-images

Responsive images for Statamic 3
MIT License
99 stars 29 forks source link

Fix fieldtype Vue component issues #156

Closed ncla closed 1 year ago

ncla commented 1 year ago

From what I found, setting this.value = value; seems redundant and the value updates, saves correctly with just this.update(value);. Removing this line fixes the warning #155

Adding :trackDirtyState="false" fixes the dirty state part of the #120 issue. The issue was if you were to save an entry with "Go to listing" save option, it would unnecessarily, annoyingly trigger the "Reload site?" prompt. The dirty state tracking still works as this ResponsiveFieldtype component is a child of another PublishContainer component which already has dirty state tracking. I assume wherever this ResponsiveFieldtype might appear, a parent component PublishContainer has dirty state tracking anyway.

riasvdv commented 1 year ago

Thanks!