spatie / statamic-responsive-images

Responsive images for Statamic 3
MIT License
99 stars 29 forks source link

Fields with errors not being highlighted after the Responsive field #237

Closed RyanEvoluted closed 4 months ago

RyanEvoluted commented 1 year ago

Bug description

When using the Responsive field, all highlighted fields after the section it's in don't seem to appear.

Example:

Section 1: Responsive Field

Section 2: Title

If the Title field is required and submitted without any input, the Title field isn't highlighted with a red border.

Screenshot 2023-09-06 at 16 25 29

When Section 2 is moved above Section 1. The Title will be highlighted as normal if no data is supplied.

Screenshot 2023-09-07 at 10 23 09

I'm expecting all the required fields to be highlighted in a red border rather than the ones that are in the same section as the responsive field or before it.

How to reproduce

  1. In a blueprint, add a 'Responsive' field to the first section
    • Make sure there's a required field in the section after it
  2. Try and create an entry for the blueprint you've edited. You should notice the required field won't be highlighted in a red border
  3. Back in the blueprint, drag the section with the 'Responsive' field after a section which has a required field
  4. Create an entry again and you should find that the requried field will be highlighted

Logs

No response

Environment

Environment
Application Name: Statamic
Laravel Version: 10.22.0
PHP Version: 8.1.15
Composer Version: 2.3.5
Environment: local
Debug Mode: ENABLED
URL: ryan_test.test
Maintenance Mode: OFF

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Broadcasting: log
Cache: statamic
Database: mysql
Logs: stack / single
Mail: smtp
Queue: sync
Session: file

Statamic
Addons: 1
Antlers: runtime
Stache Watcher: Enabled
Static Caching: Disabled
Version: 4.20.0 Solo

Statamic Addons
spatie/statamic-responsive-images: 4.1.1

Installation

Fresh statamic/statamic site via CLI

Antlers Parser

regex (default)

Additional details

This is happening on another established project but I was able to replicate this on a fresh install of Statamic.

spatie-bot commented 9 months ago

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.

spatie-bot commented 4 months ago

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.