Bump min PHP version to 8.0 in plugin header, readme and composer
Removes the build script and vendor-folder, composer is now run within the GitHub action
In comparison to Scoper, Jetpack Autoloader it is more likely to have compatibility issues. However, it makes the project more maintainable (IMHO). I have used Jetpack Autoloader for multiple projects now and haven't had issues with it.
Jetpack autoloader works best when other WordPress plugin use it too. WooCommerce and Jetpack use it - those plugins are used on millions of sites, and if it's good enough for them...
I have tested this version of the plugin with popular plugins such as WooCommerce, Jetpack, Yoast SEO and Contact Form 7 installed - and on PHP 8.0 and 8.1. This did not result in issues.
The only thing that I could not test entirely, was running composer from the deploy action. I see everything works though, up to the moment it is deployed to WordPress SVN. So it should be fine.
For your consideration @freekmurze, but I personally would go this way if it was up to me.
freekmurze
commented
1 year ago
This pull request in a nutshell:
In comparison to Scoper, Jetpack Autoloader it is more likely to have compatibility issues. However, it makes the project more maintainable (IMHO). I have used Jetpack Autoloader for multiple projects now and haven't had issues with it.
Jetpack autoloader works best when other WordPress plugin use it too. WooCommerce and Jetpack use it - those plugins are used on millions of sites, and if it's good enough for them...
I have tested this version of the plugin with popular plugins such as WooCommerce, Jetpack, Yoast SEO and Contact Form 7 installed - and on PHP 8.0 and 8.1. This did not result in issues.
The only thing that I could not test entirely, was running composer from the deploy action. I see everything works though, up to the moment it is deployed to WordPress SVN. So it should be fine.
For your consideration @freekmurze, but I personally would go this way if it was up to me.