search

spaulaus / paass-lc

Acquire and Analyze data from XIA Pixie16 modules
GNU General Public License v3.0
2 stars 7 forks source link

DataGenerator linking fails if we don't build Analysis #111

Closed spaulaus closed 6 years ago

spaulaus commented 6 years ago

Expected Behavior

DataGenerator linking shouldn't fail if we don't build the Analysis programs

Current Behavior

The DataGenerator can't link since it depends on the Analysis > ScanLibraries

Context

This program is used to generate a data file that can be scanned using the analysis.

Possible Solution (optional)

Move this utility into the Analysis/Utilities folder, and give it a special flag. The only other library that it depends on is from Core.

Acceptance Criteria

  1. The DataGenerator program is moved to Analysis/Utilities
  2. The DataGenerator program doesn't compile if we're not compiling Analysis programs
  3. The DataGenerator program can be toggled on or off (defaults to ON)

Bug Report

Your Environment

Build on TravisCI

Steps to Reproduce

  1. Build the program with -DPAASS_BUILD_ANALYSIS=OFF -DPAASS_BUILD_ACQ=ON -DPAASS_BUILD_SETUP=ON
  2. Make the software
spaulaus commented 6 years ago

Figured out a simpler way to handle this. Just added an if to check if we're building analysis. If not, then we don't build DataGenerator.

spaulaus commented 6 years ago

This issue was moved to spaulaus/paass#111