spawnia / sailor

A typesafe GraphQL client for PHP
MIT License
78 stars 18 forks source link

fix: register commands properly with sf7 #101

Closed simPod closed 9 months ago

simPod commented 10 months ago

Changes

Breaking changes

SF7 stopped using $defaultName to fetch command name. The best and easiest way seems to be to init the command with the name set.

spawnia commented 10 months ago
simPod commented 10 months ago

Does this still work with older versions?

yes it does, at least with v6. I cannot install v5 as it's too old.

I think we can even drop $defaultName now but maybe there's some purpose for it that I have not discovered.

spawnia commented 10 months ago

I will have to try this with v5.

simPod commented 10 months ago

this will work with sf5 as well