Open spawnia opened 1 year ago
I was checking #77, #78 and this for an upcoming task I'm about to take on later this week or the next.
Is it currently already possible to properly use the directives, or are there still any limitations that this PR is meant to solve?
I'd like to know the current status, as when I take on that task, if something is still amiss, I'm probably going to first try and work on this PR, instead of turning our BFF's code into a Hydra right away.
Is it currently already possible to properly use the directives, or are there still any limitations that this PR is meant to solve?
No, the problems with them are detailed in the description of this pull request. Sailor will currently not handle a field missing due to @skip
or @include
gracefully. Feel free to fork and propose a solution to this pull request, it is currently only a failing test.
https://github.com/spawnia/sailor/issues/77
Changes
When an operation tells the server to omit a field through
@skip
or@include
, the result will not contain those fields at all. Thus, the generated result must be marked nullable and be able to handle if those keys are missing.Breaking changes
I foresee none.