error messages end with a dot

spaze / phpstan-disallowed-calls

PHPStan rules to detect disallowed method & function calls, constant, namespace, attribute & superglobal usages

MIT License

255 stars 17 forks source link

error messages end with a dot #117

Closed staabm closed 2 years ago

staabm commented 2 years ago

in phpstan usually rule error messages end with a dot.

with a configuration like

    disallowedSuperglobals:
        -
            superglobal: '$_SESSION'
            message: 'use rex_request::session() and rex_request::setSession() instead for proper per instance scoping.'

it seems the extension is even trimming the configured dot.

staabm commented 2 years ago

hmm I think its somehow related to my setup.. only the last message don't have a dot it seems (I am using --error-format=raw phpstan format option)

spaze commented 2 years ago

Just for the record I'm not stripping anything (well, at least not intentionally 😅) but if you figure it out I'd definitely like to know what was it. Thanks!