disallowedAttributes: configure errorIdentifier and errorTip as optional

spaze / phpstan-disallowed-calls

PHPStan rules to detect disallowed method & function calls, constant, namespace, attribute & superglobal usages

MIT License

255 stars 17 forks source link

disallowedAttributes: configure errorIdentifier and errorTip as optional #229

Closed francescolaffi closed 10 months ago

francescolaffi commented 10 months ago

Gave a test run of some disallowed attributes on properties after #225 , noticed errorIdentifier and errorTip are considered mandatory but I'm guessing it was not intended in #222

Additionally aligned some comments on recently introduced tests (if I got correctly the meaning)

spaze commented 10 months ago

Nice catch in the parametersSchema, thanks! This was indeed a strange copy/paste bug or something, definitely not intended. I've replaced the test update with #230, I didn't like the two classes be the same except the class name and the comments (which were wrong 😅), it has actually confused me before so thanks for forcing me (in a kindly way) to do something with that.