search

spaze / phpstan-disallowed-calls

PHPStan rules to detect disallowed method & function calls, constant, namespace, attribute & superglobal usages
MIT License
255 stars 17 forks source link

Composer > Define allowed plugins #96

Closed ruudk closed 2 years ago

ruudk commented 2 years ago

Needed for Composer 2.2.0 (found with 2.2.0-RC1)

composer self-update --preview
ruudk commented 2 years ago

@spaze Tried to fix the code style error but I believe it's coming from upstream spaze/coding-standard. It should not append , in function arguments as that is not available on PHP 7.1 and 7.2.

spaze commented 2 years ago

Yeah, right, the coding standard has started requiring trailing comma recently I'll see if it can be enforced only for 7.3+.

At first I thought of dropping support for unsupported PHP versions but as PHPStan still supports them I think it would be worth the time to support those as well.

ruudk commented 2 years ago

I fixed it :)

spaze commented 2 years ago

Note to (mostly) self: the plugin is loaded because it's required by Slevomat Coding Standard which in turn is required by coding standard of yours truly: https://github.com/slevomat/coding-standard/blob/ec0e91393abbebca72de1e47e27ed98cf48f5fb1/composer.json#L16