search

spazproject / Spaz-Enyo

A version of Spaz targeted for tablet devices
http://getspaz.com
Other
45 stars 10 forks source link

Performance Fix: Column Sizing #109

Closed dcousineau closed 12 years ago

dcousineau commented 12 years ago

Removed need to call resize handlers. Turns out giving the scroller an enyo-hflexbox class gives us all the -webkit-box-flex we need.

Removed scrollfades while we're at it, those have changed for enyo and they weren't showing up anyways.

nguarracino commented 12 years ago

Do you know if className: "enyo-hflexbox" is the same as layoutKind: "HFlexLayout"? Or does enyo-hflexbox give better performance somehow?

dcousineau commented 12 years ago

For some reason just giving hflexlayout and/or hflexbox either didn't work or broke the snap. I applied that style as all I needed to do was plug what I assume is an enyo bug and give a display: -webkit-box; to the scroller so -webkit-box-flex would work.The scroller is supposed to default to hflexlayout, but the scroller div really should act like an hflexbox-- Sent from my Palm PreOn Jun 11, 2011 4:17 PM, nguarracino reply@reply.github.com wrote: Do you know if className: "enyo-hflexbox" is the same as layoutKind: "HFlexLayout"? Or does enyo-hflexbox give better performance somehow?

Reply to this email directly or view it on GitHub: https://github.com/funkatron/Spaz-Enyo/pull/109#issuecomment-1352951

nguarracino commented 12 years ago

Right on, thanks for getting to the bottom of it! I can notice the performance difference even in Chrome on my desktop!

On Sat, Jun 11, 2011 at 17:35, dcousineau < reply@reply.github.com>wrote:

For some reason just giving hflexlayout and/or hflexbox either didn't work or broke the snap. I applied that style as all I needed to do was plug what I assume is an enyo bug and give a display: -webkit-box; to the scroller so -webkit-box-flex would work.The scroller is supposed to default to hflexlayout, but the scroller div really should act like an hflexbox-- Sent from my Palm PreOn Jun 11, 2011 4:17 PM, nguarracino < reply@reply.github.com> wrote: Do you know if className: "enyo-hflexbox" is the same as layoutKind: "HFlexLayout"? Or does enyo-hflexbox give better

performance somehow?

Reply to this email directly or view it on GitHub: https://github.com/funkatron/Spaz-Enyo/pull/109#issuecomment-1352951

Reply to this email directly or view it on GitHub: https://github.com/funkatron/Spaz-Enyo/pull/109#issuecomment-1353009