search

spazproject / Spaz-Enyo

A version of Spaz targeted for tablet devices
http://getspaz.com
Other
45 stars 10 forks source link

Re-creating columns after dropping a column has issues. #132

Closed willhoney7 closed 12 years ago

willhoney7 commented 12 years ago

this.createColumns() on the spacerDrop function creates issues with starting a column drag. To replicate: Hold onto a column toolbar, move it slightly, release. It will float in an awkward postion. this doesn't happen if this.createColumns() is commented out.

funkatron commented 12 years ago

Has this been fixed?

nguarracino commented 12 years ago

Not sure, I tried the steps that Will described a few times and it seemed to be ok. The UI can lock up while the columns are being regenerated though. This was on the 3.0.2rc1 SDK.

On Mon, Jul 25, 2011 at 15:19, funkatron < reply@reply.github.com>wrote:

Has this been fixed?

Reply to this email directly or view it on GitHub: https://github.com/funkatron/Spaz-Enyo/issues/132#issuecomment-1648283

funkatron commented 12 years ago

ah yes -- this is still an issue. I think tibfib and I talked about a possible solution (checking to see if the column state is still "dragging" after a few seconds of non-movement).

With regeneration lockup, can you explain how that can be replicated?

nguarracino commented 12 years ago

I just followed the steps here - basically, pick up a column and drop it again. It's not a permanent lockup, but the UI is unresponsive while the columns are destroyed and recreated.

On Mon, Jul 25, 2011 at 15:37, funkatron < reply@reply.github.com>wrote:

ah yes -- this is still an issue. I think tibfib and I talked about a possible solution (checking to see if the column state is still "dragging" after a few seconds of non-movement).

With regeneration lockup, can you explain how that can be replicated?

Reply to this email directly or view it on GitHub: https://github.com/funkatron/Spaz-Enyo/issues/132#issuecomment-1648435

funkatron commented 12 years ago

ah right. that's gonna be an issue… I think it's just a performance thing. The caching I did prob helps a bit, but we should look for more places we can cache stuff and not have to do tasks more than once, especially anything related to dom manipulation – that kills perf.

Ed Finkler http://funkatron.com @funkatron AIM: funka7ron / ICQ: 3922133 / XMPP:funkatron@gmail.com

On Monday, July 25, 2011 at 3:42 PM, nguarracino wrote:

I just followed the steps here - basically, pick up a column and drop it again. It's not a permanent lockup, but the UI is unresponsive while the columns are destroyed and recreated.

On Mon, Jul 25, 2011 at 15:37, funkatron < reply@reply.github.com (mailto:reply@reply.github.com)>wrote:

ah yes -- this is still an issue. I think tibfib and I talked about a possible solution (checking to see if the column state is still "dragging" after a few seconds of non-movement).

With regeneration lockup, can you explain how that can be replicated?

Reply to this email directly or view it on GitHub: https://github.com/funkatron/Spaz-Enyo/issues/132#issuecomment-1648435

Reply to this email directly or view it on GitHub: https://github.com/funkatron/Spaz-Enyo/issues/132#issuecomment-1648470