search

spazproject / Spaz-Enyo

A version of Spaz targeted for tablet devices
http://getspaz.com
Other
45 stars 10 forks source link

Display Twitter API RTs correctly #45

Closed funkatron closed 13 years ago

funkatron commented 13 years ago

Twitter API RTs are funky in that they have a whole separate status object just for the full retweeted message. If you don't use that, you can lose some chars due to the 140char limit imposed. So, we need to do a little work to display them correctly.

paddycarver commented 13 years ago

Shall I just take on the mantle of Lord of the Retweets? As long as I'm tackling them, I may as well tackle them completely...

funkatron commented 13 years ago

Do it to it, dude!

Ed Finkler http://funkatron.com @funkatron AIM: funka7ron / ICQ: 3922133 / XMPP:funkatron@gmail.com

On Sunday, May 15, 2011 at 2:24 PM, paddyforan wrote:

Shall I just take on the mantle of Lord of the Retweets? As long as I'm tackling them, I may as well tackle them completely...

Reply to this email directly or view it on GitHub: https://github.com/funkatron/Spaz-Enyo/issues/45#comment_1166854

funkatron commented 13 years ago

Actually, thinking more about it, this should be mostly an issue of having AppUtils.convertToEntry() to handle the API RT situation and properly convert it, adding a new properly called "is_repost" and perhaps "repost_user" or something like that.

willhoney7 commented 13 years ago

@funkatron, that would make it super easy for paddyforan or myself to plug into Entry.js.

I think we should folow the styling of the Mojo, with the original username, a retweet icon, and then the retweeter.

funkatron commented 13 years ago

I think I've provided all the appropriate data in the Entry object now. See 1cfdbeae37bc3313733caca582812a65c2282f10

willhoney7 commented 13 years ago

Awesome, I'll hook this in shortly.

willhoney7 commented 13 years ago

I think we can consider this done!