feature-tidy - Githubissues

spboyer / advocate-linkers

6 stars 8 forks source link

feature-tidy #26

Closed johnpapa closed 4 years ago

johnpapa commented 4 years ago

Prettier and eslint
remove dead code (80+ lines)
fix social media preset bug (fixes issue #7)
barrel for modules, shorten imports
remove .vue extension
link card is own component
move link card so screen doesnt visually jump
preset formatting

johnpapa commented 4 years ago

please squash merge, after you are comfortable with this PR

spboyer commented 4 years ago

@johnpapa build failed with prettier errors

https://dev.azure.com/shayneboyer/social-linker/_build/results?buildId=457

johnpapa commented 4 years ago

Good catch. I’ll fix

johnpapa commented 4 years ago

@spboyer we may want to add a npm run lint in the pipeline. I looked at the pipeline file and I do not see the steps to build the app. I was expecting to see something like ...

npm install
npm run lint
npm run build

I see you are doing the build in Dockerfile. So I added npm run lint there. We will want ot added pipeline steps for a pre-build so we can do a cypress test run too.

No need for action now - just sharing so we can decide next steps.