search

spboyer / advocate-linkers

6 stars 8 forks source link

Fix the order of tactic/category #7

Closed MaximRouiller closed 4 years ago

johnpapa commented 4 years ago

What do you need done here?

tactic-category-alias is what we have today

MaximRouiller commented 4 years ago

The social linker should do things in this order: tactic-social-myalias

As social is the category and not twitter. When you pass the link through it, it creates social-twitter-myalias instead. This needs to be fixed.

johnpapa commented 4 years ago

Ok. So the links are wrong. Not the left right order of the inputs.

I’ll fix this. Thanks.

MaximRouiller commented 4 years ago

Exactly. twitter is being used in the category property while it should be in the tactic. All others should also be tested.

Eventually, we should have tests to validate those as well.