Hi, @yannachen. I reverted this pull request because there are some things that still need to be done before it's ready.
Most importantly, it needs tests. I recommend a separate file src/have/tests/test_robot.py. At a minimum it should verify that load_robots() works. In this case, it should probably also check that the transfer_sample() signals are correct.
Also, we should check that it works at the beamline before merging.
Lastly, we need an entry in src/haven/instrument/load_instrument.py to actually do the robot loading.
I don't see any major problems, but I don't want to allow untested things into main since that could break for users.
Hi, @yannachen. I reverted this pull request because there are some things that still need to be done before it's ready.
Most importantly, it needs tests. I recommend a separate file src/have/tests/test_robot.py. At a minimum it should verify that
load_robots()works. In this case, it should probably also check that thetransfer_sample()signals are correct.Also, we should check that it works at the beamline before merging.
Lastly, we need an entry in src/haven/instrument/load_instrument.py to actually do the robot loading.
I don't see any major problems, but I don't want to allow untested things into main since that could break for users.