search

spc-group / haven

Bluesky tools for beamlines managed by the spectroscopy group
https://haven-spc.readthedocs.io/en/latest/
Other
2 stars 5 forks source link

issues when step size is bigger than stop point in xafs_scan #197

Closed Cathyhjj closed 2 months ago

Cathyhjj commented 2 months ago

Observed issues in xafs_scan, when step size is bigger than stop point.

canismarko commented 2 months ago

For example:

start: 0 step: 50 end: 70

Which of the following is correct:

  1. [0, 50]
  2. [0, 50, 70]
  3. [0, 50, 100]
canismarko commented 2 months ago

Consensus from SKD/MAS/CJS was option 1.

canismarko commented 2 months ago

Possible fix: https://github.com/spc-group/haven/commit/d48328cf57e4a8656355bf33b8afe3483651f543

Cathyhjj commented 2 months ago

solved by Mark using np.linspace