save_motor_window development

spc-group / haven

Bluesky tools for beamlines managed by the spectroscopy group

https://haven-spc.readthedocs.io/en/latest/

Other

3 stars 6 forks source link

save_motor_window development #256

Open Cathyhjj opened 3 months ago

Cathyhjj commented 3 months ago

Discuss:

[ ] whether to add metadata to the saved motor positions rather than just names
[x] whether to add delete_saved_motor_positions(uid) functions to motor_position.py, is the beamline db also MongoDB?

Todo list

[x] make readback values and offset values in different columns
[x] add save plan in the future
[x] Refresh automatically after saving
[x] Add a filter field for dates

canismarko commented 3 months ago

is the beamline db also MongoDB?

Yes, both the motor positions and our scans get saved to the same mongo database, but in different collections.

Now that I think about it, maybe we should scrap the saved motor position collection and just do a bp.count on the motors to save their current positions.

It would mean that saving positions has to happen in a run engine, but it would open up some advantages like API access and being able to export them to a csv, etc.

Thoughts?

Cathyhjj commented 2 months ago

Status

[x] add a checkbox in front of the dates
[x] merge refreshing and filter button
[x] put a splitter to resize the component selectors and the save position TableWidget
[x] Save queue now or later()
[x] Recall now or recall later()
[x] Automatically refresh the saved motor positions after the queue status is changed

Cathyhjj commented 2 months ago

@canismarko Maybe: add name contains filter in get_motor_position

Cathyhjj commented 1 month ago

bugs:

[x] connect to PyDM signals only when the combobox edit is finished
[ ] a bug that a uid plan is loaded twice (maybe observe more and fix in the future)
[x] only enable recall now or recall on queue when something is selected/or return an error
[x] buttons to be smaller
[x] change color to blue for the names
[x] when "enter" is hit, it should refresh
[x] make date to 2024-09-09, if it supports

Cathyhjj commented 1 month ago

2024-10-15

[ ] try and except block for user_readback control
[x] try and except for the comboBox LineEdit
[ ] When initializing the window, there's always one more entry
[x] They all should be queue buttons
[x] put def update_queue_status(self, status) for queue button
[x] Wait until Mark finishes main changes on Ion chambers

Cathyhjj commented 1 month ago

[x] work on merging main into save_motor_window