search

spchuang / videojs-markers

Displays customizable markers upon progress bars of videojs players
http://sampingchuang.com/videojs-markers
MIT License
440 stars 189 forks source link

Fixed warnings #67

Closed stevenah closed 6 years ago

stevenah commented 7 years ago

Fixed warnings related to 'createEl' and 'plugin'.

vhmth commented 7 years ago

This looks great. @spchuang can we get this landed? Using .plugin instead of .registerPlugin results in the following warnings in production for us:

screen shot 2017-09-20 at 10 45 39 pm
vhmth commented 6 years ago

@spchuang if you are no longer maintaining this repo, would you like me to fork into the main Loom org? I feel this repo may be healthier if you either allow us to be the main markers repo or if (ideally) you make myself and one other Loom member (@paulius005 perhaps?) co-owners/collaborators of the repo so we have the autonomy to look at PRs and close them more quickly. I'd opt for the latter rather than us cloning into the Loom org and being the main repo since then other peeps who have this as an entry in their package.json wouldn't have to make any changes.

spchuang commented 6 years ago

That's a good plan. I will add both of you as repo collaborators so it'll be easier for you guys to close PR.

On Oct 8, 2017, at 12:56 PM, Vinay notifications@github.com wrote:

@spchuang if you are no longer maintaining this repo, would you like me to fork into the main Loom org? I feel this repo may be healthier if you either allow us to be the main markers repo or if (ideally) you make myself and one other Loom member (@paulius005 perhaps?) co-owners/collaborators of the repo so we have the autonomy to look at PRs and close them more quickly. I'd opt for the latter rather than us cloning into the Loom org and being the main repo since then other peeps who have this as an entry in their package.json wouldn't have to make any changes.

― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

vhmth commented 6 years ago

Sweet! Thanks @spchuang.

paulius005 commented 6 years ago

Thanks @spchuang!

vhmth commented 6 years ago

@spchuang it seems you use a combo of git tags and updating the README to create a changelog entry for a bump in version. How would you like me to open a PR/what's your publish flow? I'd like to bump the version for this change and update in the main Loom repo.