search

spchuang / videojs-markers

Displays customizable markers upon progress bars of videojs players
http://sampingchuang.com/videojs-markers
MIT License
440 stars 189 forks source link

It should be on ready #80

Open codex-corp opened 6 years ago

codex-corp commented 6 years ago

https://github.com/spchuang/videojs-markers/blob/04dff88f70c32d763d9962aeb5bc93410100e8a4/dist/videojs-markers.js#L447


    player.ready(function(){
        initialize();
    });
spchuang commented 6 years ago

Are there cases when the current initialization method fails for you?

abhinavatai commented 4 years ago

Are there cases when the current initialization method fails for you?

Yep. I've already initialized and added markers before player event ""loadedmetadata". When you initialize it again using this event all my previous markers are removed. This should not happen?