search

spchuang / videojs-markers

Displays customizable markers upon progress bars of videojs players
http://sampingchuang.com/videojs-markers
MIT License
440 stars 189 forks source link

videojs 6 deprication #88

Open NoamPaz opened 6 years ago

NoamPaz commented 6 years ago

videojs version: 6.8.0

use the plugin as npm package (yarn add videojs-markers)

I get 2 warnings on run time: 1) videojs.plugin() is deprecated; use videojs.registerPlugin() instead 2) videojs.createEl() is deprecated; use videojs.dom.createEl() instead

It's still working, bug it's better to fix those warning

NoamPaz commented 6 years ago

Seems like there is a pull request for this issue: https://github.com/spchuang/videojs-markers/pull/86 Is it possible to review and approve it. Thanks.

spchuang commented 6 years ago

Hi sorry for late reply. Haven’t had too much time to properly maintain the project. Yes I’ll take a look this week to approve the changes.

Sent from my iPhone

On May 21, 2018, at 7:06 AM, Noam Paz notifications@github.com wrote:

Seems like there is a pull request for this issue:

86

Is it possible to review and approve it. Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

spchuang commented 6 years ago

just accepted the pr

NoamPaz commented 6 years ago

Thanks!! Please bump the version and publish it to npm.

jakubfrydrych commented 6 years ago

Hi, thanks for fix ! Also please move the changes to npm.

fealaer commented 5 years ago

It seems like the main maintainer has left GitHub. :( Due to this, I've released new version in the fork - npm.

spchuang commented 5 years ago

Hi, I'm happy to add other folks as collaborators if anyone is interested. I can also give access to update the npm package so people can continue with the same one without having to change to a new one

Jeet-s commented 1 year ago

@spchuang Is it fixed?