spckio / spck-issues

Spck Editor Issues
https://spck.io
72 stars 15 forks source link

Private repository clone not working #29

Closed lethevimlet closed 10 months ago

lethevimlet commented 5 years ago

Private repository clone fails silently without any error information.

k41c commented 5 years ago

+1

onlyrams commented 5 years ago

Also experiencing

spck-io commented 4 years ago

Is this for Github, Gitlab, Bitbucket, or some other host?

onlyrams commented 4 years ago

I am having issues when using GitHub, I don't use any of the other integrations.

Is there any logging I would be able to get for you, to help with the issue?

Thanks

spck-io commented 4 years ago

I have fixed this problem for gitlab. Unfortunately I do not have a private GitHub account to test private repos. This change is pushed to the latest editor version (0.6.0, which can be checked under the settings tab menu).

For 0.6.0 I will aim to fix all git integration issues with the editor.

onlyrams commented 4 years ago

Would it help if I provided you a token to my private git repo?

spck-io commented 4 years ago

I have released a new android app 2.0.1. This was a bug in the android proxy that somehow only affected private repo cloning. Let me know if you experience issue after updating the android app. The proxy is needed as the app runs in a webview and Gitlab, Github, Bitbucket automatically rejects CORS.

pankajsays commented 4 years ago

I am trying to clone locally hosted gitea private repository. It errors out saying not found. I am able to clone with git clone https://user:token@url.git

spck-io commented 4 years ago

Are you using an app token or a password? I have encountered this for gitlab and found when the app token doesn’t have the permissions to read/write to the repo, it will spit back a 404 error.

pankajsays commented 4 years ago

I tried with token, it did not work. I made the repo public, then also it did not work. is it possible to add support for key based clone with ssh. And could you share what technology you used to build the app if you don't mind? the app is awesome

spck-io commented 4 years ago

I’m using service workers and isomorphic git for the git stuff. Could you share a link of the public repo that’s not working for you? I still suspect for the public repo case there’s something wrong with your token, you can delete it and try, I never had any issues with cloning public repos. Are you checking off read and write repo options when creating the token? Maybe try checking off all the permission scopes for the token? Also right now git sub modules are not supported by isomorphic git, but it shouldn’t prevent cloning.

zxsanny commented 4 years ago

Bitbucket clone from private repo doesn't work as well. Used app token. Says "clone failed because http url could not be found"

dnazirso commented 4 years ago

Same as @zxsanny clone failed because http url could not be found

spck-io commented 4 years ago

Please update Android app to version 3.0.6 and let me know if there are any further problems with cloning.

orestis-z commented 4 years ago

I have the same issue for bitbucket repos (both public and private) on v3.0.8. Getting clone failed because http url could not be found too

spck-io commented 4 years ago

There seemed it be a problem specifically with Bitbucket. One issue that was fixed was the clone URL Bitbucket provided has a username which the HTML fetch API didn’t like. The git library the editor uses, parses out the username into a header which Bitbucket also didn’t like. This issue has been fixed in a editor version 0.9.6.

orestis-z commented 4 years ago

Great, is the fix pushed to the play store already?

ghost commented 4 years ago

Bitbucket clone from private repo doesn't work as well. Used app token. Says "clone failed because http url could not be found"

I'm getting the same issue with GitHub on a private repo

spck-io commented 4 years ago

Have you upgraded to the latest android app 3.0.12? Make sure to create an app token with full repository access rights. I have just cloned a private repo yesterday from bitbucket. If you are unsure about the access rights, just check all the boxes. Some hosts returns a 404 when the token does not have read permissions to the repo

orestis-z commented 4 years ago

Still can't pull public repo on 3.1.0 Trying to pull this one: https://bitbucket.org/zamponotiropita/opsworks-cookbooks.git

spck-io commented 4 years ago

I updated the editor to 3.1.1. It seems like sometimes Bitbucket is returning an empty HTTP status message with a 200 status code which was throwing off the proxy server in Android (To avoid browser CORS issues). This was fixed by manually looking up the status message for each status code in the latest version.

orestis-z commented 4 years ago

Ok works. Seems like my credentials are removed everytime that I update the android up. Which is a problem since I have to recreate the token each time as I can copy it only once from bitbucket

orestis-z commented 4 years ago

Update: seems like credentials lost even without update (can't pull anymore)

spck-io commented 4 years ago

Git credentials have been moved to a file in the recent update, it is no longer stored using localStorage, this should prevent loss of credentials between updates or randomly.

Vivraan commented 4 years ago

I get this when I try to pull from a public or private repo from GitHub, which I "clone" (the app basically restarts once the option is chosen).

Screenshot_2020-08-13-19-13-15-59

desoter commented 3 years ago

Hello, I have this issue when cloning a private git repository, hosted on my server. I get "HTTP 301 moved permanently" but from any desktop environment it works fine. Also, I only have https (443) channel active on the server so the redirect message makes no sense to me. Let me know if I can provide more info to help understand the issue. Thank you!

Edit: my issue is now solved!

m0h4mm4d-h053n commented 3 years ago

Screenshot_2021-06-08-16-37-37-81 I am facing problem whenever i pull the file from spck editor. Its saying can't read poperty lenth of null. How can i fix this?

ghost commented 3 years ago

On my android tablet, it is stuck on fetching pack file

Timberwavy commented 3 years ago

Please how do I fix this ![Uploading Screenshot_20210728-044154.png…]()

inxomnyaa commented 2 years ago

Latest Android version and i am hitting this on private repos Screenshot_20220515-041426~2

Kazuto commented 2 months ago

I'm still having this issue to this day. I've tried the classic token and the new token type but I can't clone or push to my repos, even when checking all permissions when creating a token.

EDIT I've found the issue. It was a space after the token.

Screenshot_2024-06-25-09-31-06-919_io.spck-edit.jpg